Extend with absent endpoints#5
Merged
cjacobsen-hw merged 4 commits intohyperwallet:masterfrom May 25, 2018
Merged
Conversation
Gandi24
reviewed
May 14, 2018
| from hyperwallet.exceptions import HyperwalletAPIException | ||
| from requests_toolbelt.adapters.ssl import SSLAdapter | ||
| from hyperwallet import __version__ | ||
| try: |
There was a problem hiding this comment.
I'd consider using six or future library.
Six:
http://six.readthedocs.io/
from six.moves import urllib or alternatively conditional using six.PY2 or six.PY3 variables.
Future:
http://python-future.org/compatible_idioms.html#urllib-module
Contributor
There was a problem hiding this comment.
Thank you for the feedback, we will consider it for the next update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend with absent endpoints